search

rooch-network / rooch

VApp Container with Move Language
https://rooch.network
Apache License 2.0
128 stars 54 forks source link

[Example] Add test case for private generics in the examples directory. #296

Closed feliciss closed 8 months ago

feliciss commented 11 months ago

Add test case for #289

jolestar commented 11 months ago

the test case should not be put in the example dir. It should be in the rooch-framework-tests

jolestar commented 11 months ago

the test case should not be put in the example dir. It should be in the rooch-framework-tests

It is ok to put in the example's integration-tests dir.

feliciss commented 11 months ago

the test case should not be put in the example dir. It should be in the rooch-framework-tests

It is ok to put in the example's integration-tests dir.

Like these two test cases?

examples/counter/integration-tests/counter.exp
examples/counter/integration-tests/counter.move

And we should also write test cases in rooch-framework-tests for unit tests and rooch-integration-test-runner for integration tests?

jolestar commented 11 months ago

I think the private_generics integration tests should be in the rooch-framework-tests, The private_generics example is a demo for giving application developers, showing how to use the private_generics.

rooch-integration-test-runner's test cases just for test the runner self.

feliciss commented 11 months ago

I think the private_generics integration tests should be in the rooch-framework-tests, The private_generics example is a demo for giving application developers, showing how to use the private_generics.

rooch-integration-test-runner's test cases just for test the runner self.

Got it.

jolestar commented 8 months ago

Close this; feel free to reopen it if it is still needed.