rooch-network / rooch

VApp Container with Move Language
https://rooch.network
Apache License 2.0
128 stars 54 forks source link

[gh-786] Add Ethereum RPC client API to client library. #788

Closed feliciss closed 7 months ago

feliciss commented 8 months ago

Summary

Continuing after #787.

Add Ethereum RPC client API to client library.

vercel[bot] commented 8 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **rooch** | ⬜️ Ignored ([Inspect](https://vercel.com/rooch/rooch/q6bWTbjyfiuLYsQqPa7chsnwQmRd)) | [Visit Preview](https://rooch-git-fork-feliciss-786-rooch.vercel.app) | | Oct 9, 2023 7:06pm |
baichuan3 commented 8 months ago

Next, I will refactor the key store to resolve https://github.com/rooch-network/rooch/issues/755. Before starting, please confirm that the refactor related to the key store in this PR will continue to be valid and will be merged into the main branch? @feliciss

feliciss commented 8 months ago

Next, I will refactor the key store to resolve #755. Before starting, please confirm that the refactor related to the key store in this PR will continue to be valid and will be merged into the main branch? @feliciss

Not sure. I have a batch of commits that will be continuing after #788 to modify the key store.

Cuz this PR is mainly for RPC API, not heavily related to key store features.

Probably I'll modify these lines to change the generics:

https://github.com/rooch-network/rooch/blob/ac6a11cf8f2469c38e1c6a13dcbcdedde569a195/crates/rooch-key/src/keystore.rs#L565-L576

If it's not related to generics or it's not big changes, you can do refactors with it.

baichuan3 commented 8 months ago

Cuz

get it

feliciss commented 7 months ago

Can you check what the cause it is when running cargo test -p testsuite --test integration? May it relate to #842? @jolestar

✘  Then assert: "{{$.move[-1].execution_info.status.type}} == executed"
Step failed:
Defined: features/cmd.feature:59:7
Matched: crates/testsuite/tests/integration.rs:103:1
Step panicked. Captured output: expected 3 arguments: first [==|!=] second, but got input " == executed"
pause125 commented 7 months ago

Can you check what the cause it is when running cargo test -p testsuite --test integration? May it relate to #842? @jolestar

✘  Then assert: "{{$.move[-1].execution_info.status.type}} == executed"
Step failed:
Defined: features/cmd.feature:59:7
Matched: crates/testsuite/tests/integration.rs:103:1
Step panicked. Captured output: expected 3 arguments: first [==|!=] second, but got input " == executed"

Can you please figure out which command caused this error? It seems the last rooch move command is failed which is expected success. You can also run the failed command in you shell and see the detailed output.

jolestar commented 7 months ago

this PR only implements the Ethereum RPC client, do not change the KeyStore or WalletContext.

feliciss commented 7 months ago

Will remove key store refactoring and only keep Ethereum RPC client and add test cases.

feliciss commented 7 months ago

Can you check what the cause it is when running cargo test -p testsuite --test integration? May it relate to #842? @jolestar

✘  Then assert: "{{$.move[-1].execution_info.status.type}} == executed"
Step failed:
Defined: features/cmd.feature:59:7
Matched: crates/testsuite/tests/integration.rs:103:1
Step panicked. Captured output: expected 3 arguments: first [==|!=] second, but got input " == executed"

Can you please figure out which command caused this error? It seems the last rooch move command is failed which is expected success. You can also run the failed command in you shell and see the detailed output.

This issue has been resolved.