Closed feliciss closed 7 months ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Next, I will refactor the key store to resolve https://github.com/rooch-network/rooch/issues/755. Before starting, please confirm that the refactor related to the key store in this PR will continue to be valid and will be merged into the main branch? @feliciss
Next, I will refactor the key store to resolve #755. Before starting, please confirm that the refactor related to the key store in this PR will continue to be valid and will be merged into the main branch? @feliciss
Not sure. I have a batch of commits that will be continuing after #788 to modify the key store.
Cuz this PR is mainly for RPC API, not heavily related to key store features.
Probably I'll modify these lines to change the generics:
If it's not related to generics or it's not big changes, you can do refactors with it.
Cuz
get it
Can you check what the cause it is when running cargo test -p testsuite --test integration
? May it relate to #842? @jolestar
✘ Then assert: "{{$.move[-1].execution_info.status.type}} == executed"
Step failed:
Defined: features/cmd.feature:59:7
Matched: crates/testsuite/tests/integration.rs:103:1
Step panicked. Captured output: expected 3 arguments: first [==|!=] second, but got input " == executed"
Can you check what the cause it is when running
cargo test -p testsuite --test integration
? May it relate to #842? @jolestar✘ Then assert: "{{$.move[-1].execution_info.status.type}} == executed" Step failed: Defined: features/cmd.feature:59:7 Matched: crates/testsuite/tests/integration.rs:103:1 Step panicked. Captured output: expected 3 arguments: first [==|!=] second, but got input " == executed"
Can you please figure out which command caused this error? It seems the last rooch move
command is failed which is expected success. You can also run the failed command in you shell and see the detailed output.
this PR only implements the Ethereum RPC client, do not change the KeyStore or WalletContext.
Will remove key store refactoring and only keep Ethereum RPC client and add test cases.
Can you check what the cause it is when running
cargo test -p testsuite --test integration
? May it relate to #842? @jolestar✘ Then assert: "{{$.move[-1].execution_info.status.type}} == executed" Step failed: Defined: features/cmd.feature:59:7 Matched: crates/testsuite/tests/integration.rs:103:1 Step panicked. Captured output: expected 3 arguments: first [==|!=] second, but got input " == executed"
Can you please figure out which command caused this error? It seems the last
rooch move
command is failed which is expected success. You can also run the failed command in you shell and see the detailed output.
This issue has been resolved.
Summary
Continuing after #787.
Add Ethereum RPC client API to client library.