Closed baichuan3 closed 8 months ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
@wow-sven The flow of obtaining transaction list through Explorer or Dashboard is above. And the SDK needs to modify due to API changes.
Rooch's tx order is determined before execution. How about keeping both getTransactionByTxOrder
and getTransaction
(ByHash)? Make the client and SDK simpler. getTransactionByTxOrder also can used to sync tx between rooch nodes.
Rooch's tx order is determined before execution. How about keeping both
getTransactionByTxOrder
andgetTransaction
(ByHash)? Make the client and SDK simpler. getTransactionByTxOrder also can used to sync tx between rooch nodes.
For now getTransaction(ByHash)
get one Tx and getTransactions
get multi Txs, I feel doesn't get your point.
Rooch's tx order is determined before execution. How about keeping both
getTransactionByTxOrder
andgetTransaction
(ByHash)? Make the client and SDK simpler. getTransactionByTxOrder also can used to sync tx between rooch nodes.
If Rooch's tx order is determined before execution, we can consider writing sequencer order into TypeTransaction so that we can obtain the transaction list through one API.
Encounter an CI error due to dashboard.rs
, help to have a look @wow-sven
For now
getTransaction(ByHash)
get one Tx andgetTransactions
get multi Txs, I feel doesn't get your point.
We can provide both getTransactionsByTxOrder for scanning the tx list and getTransactions(ByHash) for multi-get by hash.
We already have a tx_seq_info_mapping
storage that keeps tx_order -> tx_hash mapping, Implementing this on the server side is more efficient.
For now
getTransaction(ByHash)
get one Tx andgetTransactions
get multi Txs, I feel doesn't get your point.We can provide both getTransactionsByTxOrder for scanning the tx list and getTransactions(ByHash) for multi-get by hash.
We already have a
tx_seq_info_mapping
storage that keeps tx_order -> tx_hash mapping, Implementing this on the server side is more efficient.
Already Implementing in getTransactionsByOrder
, For details, see the Summary at the top.
resolve https://github.com/rooch-network/rooch/issues/754 and https://github.com/rooch-network/rooch/issues/763
Summary 1, Aggregate and simplify transaction RPC, provide both
getTransactionsByOrder
for scanning the tx list andgetTransactionsByHash
for multi-get by hash.TransactionReturn
, including transaction, sequence_info and execution_info, aggregate returns ingetTransactionsByOrder
APIgetTransactionInfosByTxHash
APIgetTransactionByHash
is still retained. If the API is used infrequently, it may be considered to be removed.2, Save sequencer last_order to rooch store, meanwhile check
last_order
when server restart.3, The flow of obtaining transaction list through Explorer or Dashboard: Call the
rooch_getTransactionsByOrder
API to obtain the transaction list (transaction hash) according to sequence order.or Call the
rooch_getTransactionsByHash
API to obtain the Transaction list in batches.