search

roocs / clisops

Climate Simulation Operations
https://clisops.readthedocs.io/en/latest/
Other
21 stars 9 forks source link

Removed mention of git submodule in docs #112

Closed agstephens closed 3 years ago

agstephens commented 3 years ago

Simple pull request to add to previous PR. Removes documentation about git submodules. No breaking issues.

agstephens commented 3 years ago

@ellesmith88 sorry, I missed this change in the original PR.

ellesmith88 commented 3 years ago

@agstephens I was going to do this but I think the xclim-testdata submodule needs to be initiated for a few json files?

agstephens commented 3 years ago

@ellesmith88 : okay, I hadn't realised that. I'll ask Ouranos...

@Zeitsperre: do you still need the xclim test data as a submodule in the clisops git repo? I think we are ready to dissociate the mini-esgf-data submodule now.

cehbrecht commented 3 years ago

xclim test data is still used in the core: https://github.com/roocs/clisops/blob/20bbd4662b6272ec0115425f009059b85c83121e/tests/core/test_subset.py#L12

Can we replace the test files by our esgf dummy data or add the needed files to our own test-data repo xclim/...?

Zeitsperre commented 3 years ago

@agstephens I was going to do this but I think the xclim-testdata submodule needs to be initiated for a few json files?

If I follow correctly, the JSON files you mention are small enough that they can be gathered via the get_file method as well. For Xclim purposes, they were small enough that we simply loaded them into the library itself (https://github.com/Ouranosinc/xclim/tree/master/tests/testdata).

ellesmith88 commented 3 years ago

Closed as already implemented in c3s_mapping branch