[x] This PR addresses an already opened issue (for bug fixes / features)
This PR fixes issue #143
[x] Tests for the changes have been added (for bug fixes / features)
[ ] Documentation has been added / updated (for bug fixes / features)
[x] HISTORY.rst has been updated (with summary of main changes)
[x] I have added my relevant user information to AUTHORS.md
What kind of change does this PR introduce?:
Fixes a bug where if lat/lon are coordinates by a name other than "lat" or "lon" then latitude and longitude were not identified on the dataset.
After discussion on #143 I have removed the check_latlon_dimnames decorator and found lat and lon using cf-xarray. For subset_bbox it was important to get lat and lon via da[lat.name] rather than just using lat or lon as in this case lat and lon were removed from da.lat.coords and da.lon.coords and this changed the behaviour of subset_bbox.
Does this PR introduce a breaking change?:
No
Other information:
Also removed the conda environment for the docs
Pull Request Checklist:
[x] This PR addresses an already opened issue (for bug fixes / features)
[x] Tests for the changes have been added (for bug fixes / features)
[ ] Documentation has been added / updated (for bug fixes / features)
[x] HISTORY.rst has been updated (with summary of main changes)
[x] I have added my relevant user information to
AUTHORS.mdWhat kind of change does this PR introduce?: Fixes a bug where if lat/lon are coordinates by a name other than "lat" or "lon" then latitude and longitude were not identified on the dataset. After discussion on #143 I have removed the
check_latlon_dimnamesdecorator and found lat and lon usingcf-xarray. Forsubset_bboxit was important to get lat and lon viada[lat.name]rather than just usinglatorlonas in this case lat and lon were removed fromda.lat.coordsandda.lon.coordsand this changed the behaviour ofsubset_bbox.Does this PR introduce a breaking change?: No
Other information: Also removed the conda environment for the docs