roocs / clisops

Climate Simulation Operations
https://clisops.readthedocs.io/en/latest/
Other
21 stars 9 forks source link

Fix for xESMF 0.6.1 #190

Closed aulemahal closed 3 years ago

aulemahal commented 3 years ago

Pull Request Checklist:

huard commented 3 years ago

Are the non-implemented errors expected ?

aulemahal commented 3 years ago

Not at all and I can't see how my PR would have triggered those?

huard commented 3 years ago

@ellesmith88 Any idea on what could be causing this ?

ellesmith88 commented 3 years ago

@aulemahal @huard From a quick look, this is to do with the newer releases of pandas and xarray. This error appears when using pandas>=1.3.0 and xarray>0.18.2. Seems to be to do with this PR https://github.com/pydata/xarray/pull/5359

Also see https://github.com/roocs/clisops/issues/185

ellesmith88 commented 3 years ago

@aulemahal @huard The suggested workaround for this for now is https://github.com/roocs/clisops/commit/c21275fd962ec7fbf48ec28c70b422a5bb37da11.

I've tested the fix locally in your branch and all tests passed for me. The fix is in a clisops branch - dask-error-workaround ( https://github.com/roocs/clisops/tree/dask-error-workaround), if you merge this in the issue should be resolved.

The PR looks good otherwise.

huard commented 3 years ago

Thanks !

agstephens commented 3 years ago

Should be ready to merge. @agstephens double check.

agstephens commented 3 years ago

@aulemahal please add a line into HISTORY.rst to record the change - then we can merge this to master. Thanks

agstephens commented 3 years ago

Thanks @aulemahal