roocs / clisops

Climate Simulation Operations
https://clisops.readthedocs.io/en/latest/
Other
21 stars 9 forks source link

Fix broken notebooks aliases and address all docs warnings #232

Closed Zeitsperre closed 2 years ago

Zeitsperre commented 2 years ago

Pull Request Checklist:

Not really. There are some section links that have changed, but this would only affect external links to specific sections of the documentation.

Zeitsperre commented 2 years ago

@agstephens

This is good for review.

This PR fixes most of the documentation that was failing to build. There is a notebook that has programmatic errors. This is probably because of an API change in xarray. The docs will still render this notebook, but it should be fixed.

Once that's been addressed, we should remove nbsphinx_allow_errors = True from the docs/conf.py.

Zeitsperre commented 2 years ago

There seems to be a general problem with Python3.7. Serious hanging when resolving dependencies.

Python3.7 is still supported, but only for security fixes as of March 2022 (PEP537. Do we still want to support it?

agstephens commented 2 years ago

Thanks @Zeitsperre, this looks great.

agstephens commented 2 years ago

There seems to be a general problem with Python3.7. Serious hanging when resolving dependencies.

Python3.7 is still supported, but only for security fixes as of March 2022 (PEP537. Do we still want to support it?

@cehbrecht: do you have any need to retain support for Python3.7?

cehbrecht commented 2 years ago

@cehbrecht: do you have any need to retain support for Python3.7?

short answer: no. We can got to Python >=3.8

Longer answer: there is still an issue in pywps with multiprocessing job queue. It does not work with Python >=3.8. But we are using slurm ... so we are safe :)

agstephens commented 2 years ago

Hi @Zeitsperre, we are happy to retire support for Python3.7.