roocs / clisops

Climate Simulation Operations
https://clisops.readthedocs.io/en/latest/
Other
21 stars 9 forks source link

Update testing suite #272

Closed Zeitsperre closed 1 year ago

Zeitsperre commented 1 year ago

Pull Request Checklist:

Not really, no.

cehbrecht commented 1 year ago

@Zeitsperre sounds good to use micromamba :) Does the test 3.9 fail due to incompatibilities with the latest xarray? Should the upstream test be allowed to fail?

Zeitsperre commented 1 year ago

@cehbrecht

That's precisely the reason why the conda-build is failing (I'm going to rename the tests to add the upstream flag for clarity here). I don't think the upstream build should be a blocker to merging a PR (it's something the maintainers need to keep an eye, not the contributors).

As it stands, the only thing blocking merge is an approving review. If we want to make some builds "required" in order to merge (like we have on xclim) that's something we could do. Thoughts?

cehbrecht commented 1 year ago

@Zeitsperre I thought we could have an xfail for the upstream test ...

Zeitsperre commented 1 year ago

@cehbrecht

Thanks for the approval. Merging now.

We can set things up that way (technically, it's already setup that way). If we set the build to continue-on-failure, We won't see the red X-mark any more (which defeats the purpose in my mind; we don't know if it failed unless we look for ourselves). Neither solution seems ideal.