Closed huard closed 1 year ago
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
clisops/core/subset.py | 0 | 8 | 0.0% | ||
<!-- | Total: | 0 | 8 | 0.0% | --> |
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
clisops/core/subset.py | 1 | 77.54% | ||
<!-- | Total: | 1 | --> |
Totals | |
---|---|
Change from base Build 4918272074: | 0.0% |
Covered Lines: | 1110 |
Relevant Lines: | 1403 |
Also simplified logic, and added test.
Pull Request Checklist:
[x] This PR addresses an already opened issue (for bug fixes / features)
[x] Tests for the changes have been added (for bug fixes / features)
[ ] Documentation has been added / updated (for bug fixes / features)
[x] HISTORY.rst has been updated (with summary of main changes)
[ ] I have added my relevant user information to
AUTHORS.md
What kind of change does this PR introduce?: Bug fix.
Does this PR introduce a breaking change?: Should not.
Other information: