[ ] This PR addresses an already opened issue (for bug fixes / features)
This PR fixes issue #xyz
[x] Tests for the changes have been added (for bug fixes / features)
[ ] Documentation has been added / updated (for bug fixes / features)
[x] HISTORY.rst has been updated (with summary of main changes)
[ ] I have added my relevant user information to AUTHORS.md
What kind of change does this PR introduce?:
Adds the case for a dataset where the lon and lat coords are 1D and share a dimension. This is the case for station data, for example. "locstream" is the word used in ESMF, I didn't have a better idea.
The changes are located in mostly subset_bbox, but it also required a small change in create_masks so that subset_shape would work too.
In subset_bbox, for the curvilinear case, I also removed drop=True from the code. It is not doing anything because we are already clipping to the smallest box above, but more importantly, if it was doing anything it would fail in the dataset case. Some var would have coords dropped and be added back in the dataset, where the full coords still exist.
Pull Request Checklist:
[ ] This PR addresses an already opened issue (for bug fixes / features)
[x] Tests for the changes have been added (for bug fixes / features)
[ ] Documentation has been added / updated (for bug fixes / features)
[x] HISTORY.rst has been updated (with summary of main changes)
[ ] I have added my relevant user information to
AUTHORS.md
What kind of change does this PR introduce?: Adds the case for a dataset where the lon and lat coords are 1D and share a dimension. This is the case for station data, for example. "locstream" is the word used in ESMF, I didn't have a better idea.
The changes are located in mostly
subset_bbox
, but it also required a small change increate_masks
so thatsubset_shape
would work too.In
subset_bbox
, for the curvilinear case, I also removeddrop=True
from the code. It is not doing anything because we are already clipping to the smallest box above, but more importantly, if it was doing anything it would fail in the dataset case. Some var would have coords dropped and be added back in the dataset, where the full coords still exist.Does this PR introduce a breaking change?: No.
Other information: @vindelico @sarahclaude