roocs / clisops

Climate Simulation Operations
https://clisops.readthedocs.io/en/latest/
Other
21 stars 9 forks source link

Add support for locstream lon/lat in bbox and shape subsetting #288

Closed aulemahal closed 1 year ago

aulemahal commented 1 year ago

Pull Request Checklist:

The changes are located in mostly subset_bbox, but it also required a small change in create_masks so that subset_shape would work too.

In subset_bbox, for the curvilinear case, I also removed drop=True from the code. It is not doing anything because we are already clipping to the smallest box above, but more importantly, if it was doing anything it would fail in the dataset case. Some var would have coords dropped and be added back in the dataset, where the full coords still exist.

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 5392226100


Totals Coverage Status
Change from base Build 5391770466: 0.05%
Covered Lines: 1107
Relevant Lines: 1411

💛 - Coveralls