coveralls
commented
1 year ago Pull Request Test Coverage Report for Build 5381474147
- 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
- No unchanged relevant lines lost coverage.
- Overall coverage increased (+0.2%) to 78.409%
| Totals | |
|---|---|
| Change from base Build 5325640378: | 0.2% |
| Covered Lines: | 1104 |
| Relevant Lines: | 1408 |
Pull Request Checklist:
[ ] This PR addresses an already opened issue (for bug fixes / features)
[x] Tests for the changes have been added (for bug fixes / features)
[x] Documentation has been added / updated (for bug fixes / features)
[x] HISTORY.rst has been updated (with summary of main changes)
[x] I have added my relevant user information to
AUTHORS.mdWhat kind of change does this PR introduce?: Remove the pygeos "fast-path" in
create_mask. The improvements ofpygeosare now integrated in shapely 2.0 and the latest geopandas. Moreover, when testing with shapely 2.0.1, the "slow" path that used "shapely.vectorized" was much faster than the "fast" one with pygeos.Does this PR introduce a breaking change?: No.
A specific env with shapely < 2 and pygeos installed, might be slower with this branch than before. But I'm assuming shapely 2 would be way more common. Also, it's only a minor performance improvement.