Closed vindelico closed 1 year ago
Totals | |
---|---|
Change from base Build 5579360884: | 0.06% |
Covered Lines: | 1111 |
Relevant Lines: | 1415 |
@vindelico Do you have any free time to work on/finalize this PR? I have use cases that could benefit from your changes!
@vindelico Do you have any free time to work on/finalize this PR? I have use cases that could benefit from your changes!
Can you check HISTORY.rst and AUTHORS.rst, plz? - otherwise I don't have additional changes.
Define the
inner_mask
insubset_shape()
for the locstream case.subset_shape()
would return all lat/lon insideinner_mask
which is equivalent to the bounding box of the polygon, not the area inside the polygon.Pull Request Checklist:
[x] This PR addresses an already opened issue (for bug fixes / features)
subset_shape(...)
would return all points in the bounding box without filtering the points inside the polygon.[x] Tests for the changes have been added (for bug fixes / features)
[ ] Documentation has been added / updated (for bug fixes / features)
[x] HISTORY.rst has been updated (with summary of main changes)
[x] I have added my relevant user information to
AUTHORS.md
What kind of change does this PR introduce?: The inner_mask in
subset_shape()
is defined for the locstream case.Does this PR introduce a breaking change?: No.
Other information: