Fix issue 308 fillvalue

cehbrecht commented 9 months ago

Pull Request Checklist:

[x] This PR addresses an already opened issue (for bug fixes / features)
- This PR fixes issue #308
[x] Tests for the changes have been added (for bug fixes / features)
[ ] Documentation has been added / updated (for bug fixes / features)
[x] HISTORY.rst has been updated (with summary of main changes)
[x] I have added my relevant user information to AUTHORS.md

What kind of change does this PR introduce?:

Bug fix for issue #308

Does this PR introduce a breaking change?:

no.

Other information:

adds pin for xarray<=2023.3.0 to avoid regrid test failures
adds a notebook for issue testing

coveralls commented 9 months ago

Pull Request Test Coverage Report for Build 7049970048

5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.09%) to 72.201%

Totals
Change from base Build 7049731524:	0.09%
Covered Lines:	1709
Relevant Lines:	2367

💛 - Coveralls

sol1105 commented 9 months ago

@cehbrecht I explained the changes in #308. I edited your test to assert the data type of the missing value and to assert the warning message is included in the logs. It works but if there is an easier / better way to check the logs, or you think asserting the log entry is not necessary, please adjust it.

Locally all tests (incl. the remapping tests) pass. Here (with the latest xarray version) some remapping tests fail as expected.

roocs / clisops