Add core/average.py/average_shape to ops/average.py

roocs / clisops

Climate Simulation Operations

https://clisops.readthedocs.io/en/latest/

Other

21 stars 9 forks source link

Add core/average.py/average_shape to ops/average.py #312

Closed charlesgauthier-udm closed 8 months ago

charlesgauthier-udm commented 8 months ago

Pull Request Checklist:

[~] This PR addresses an already opened issue (for bug fixes / features)
- This PR is related to this issue outside of clisops
[X] Tests for the changes have been added (for bug fixes / features)
[X] Documentation has been added / updated (for bug fixes / features)
- The new ops/average_shape is documented based on the other functions in ops/average.py, Please let me know if anything else needs to be added.
[X] HISTORY.rst has been updated (with summary of main changes)
[X] I have added my relevant user information to AUTHORS.md

What kind of change does this PR introduce?:

This PR exposes average_Shape from clisops/core to clisops/ops

Does this PR introduce a breaking change?:

Not to my knowledge

Other information:

As mentioned above, this PR is part of the work related to this issue outside of clisops

github-actions[bot] commented 8 months ago

Welcome, new contributor!

It appears that this is your first Pull Request. To give credit where it's due, we ask that you add your information to the AUTHORS.rst:

[x] The relevant author information has been added to AUTHORS.rst

Please make sure you've read our contributing guide. We look forward to reviewing your Pull Request shortly ✨

coveralls commented 8 months ago

Pull Request Test Coverage Report for Build 7277865257

10 of 23 (43.48%) changed or added relevant lines in 4 files are covered.
No unchanged relevant lines lost coverage.
Overall first build on savg at 72.348%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
clisops/core/average.py	1	2	50.0%
clisops/ops/average.py	7	19	36.84%
<!--	Total:	10	23	43.48%	-->

Totals
Change from base Build 7277603029:	72.3%
Covered Lines:	1732
Relevant Lines:	2394

@huard The reason for needing to perform an update after creating the environment is because more recent versions of xarray don't support some cftime objects (see: https://github.com/pydata/xarray/issues/7794).

The workaround is to not install the latest xarray when using xESMF (not a great solution, but we weren't sure how else to proceed).

Zeitsperre commented 8 months ago

Congrats @charlesgauthier-udm !

I'll stage a new release, given that we now have some new functions from both you and Martin (@sol1105).