search

roocs / clisops

Climate Simulation Operations
https://clisops.readthedocs.io/en/latest/
Other
21 stars 9 forks source link

Add missing `rtree` dependency to ensure correct spatial indexing #36

Closed Zeitsperre closed 4 years ago

Zeitsperre commented 4 years ago

In the process of adding clisops to xclim, I discovered the source of the failing subset tests.

It appears that depending on the way that geopandas is installed, it won't necessarily come bundled with the spatial indexing library rtree, which is needed for some specific geopandas functions. This library was conditionally installed in xclim's setup.py and was probably overlooked when the code was ported here.

Adding this library to the requirements has fixed the final failing tests in /tests/core/test_subset.py/. This should be released on PyPI conda-forge as a bugfix patch.

This PR fixes #9

cehbrecht commented 4 years ago

@Zeitsperre thanks for fixing this :)

You have run bumpversion but it is not tagged yet? So we can make the 0.3.1 release on master? Need to update the release date in history.md.

Do you want to keep the commits in this PR? Please feel free to merge yourself.

Zeitsperre commented 4 years ago

I typically tag releases from master, after everything is merged (hence why the date is not set in the 0.3.1 release). I will add the date for today but I'll leave you to tag from master.

Also, I don't have push access to master. It might be that clisops access is under a different team at roocs?

Zeitsperre commented 4 years ago

@cehbrecht This is good to be merged! Thanks!

Update: All that needs adjusting is the release date! Otherwise, good to go!

cehbrecht commented 4 years ago

@Zeitsperre I have given you write access.