rooey / chromeos-filesystem-onedrive

This project provides a OneDrive FileSystem mount for ChromeOS
http://onedrivefs.justmichael.uk/
BSD 3-Clause "New" or "Revised" License
36 stars 20 forks source link

OneDrive - An operation is taking longer than expected. Do you want to abort it? #23

Closed phillym closed 5 years ago

phillym commented 6 years ago

Hi,

Thanks for adding preliminary OfB support! Very cool.

The extension seems to have to problems/time-out issues.

phillym commented 6 years ago

I right-clicked OneDrive in the Files App list and selected 'Close'. I then re-added via 'Add new services'

Now I can browse OneDrive and view files and folders but if I try to open a file I receive refresh token error as above but also see the following error in the logs every time I try to open a file (for example a txt or jpg file:

So this looks like CORS issue?

rooey commented 6 years ago

Yes this is a weird one. Will take a look when I get a mo. I must have messed something up there :)

LSeelig commented 6 years ago

Yes. This, unfortunately, renders the app useless. I am stuck on a Chromebook and am firmly glued to the Microsoft ecosystem for both work and school. I now spend my time pulling drive files from my personal and school accounts through both the web and android version, both of which were someone reliable. If you could get this working, your app would be a godsend. Also, I am testing it with an OfB account, but in the past, I have had this issue with my personal account.

LSeelig commented 6 years ago

Also, another note: This is through multiple devices and before the 2.0 update. With some school owned Chromebooks, I am pretty sure I also experienced this issue.

LSeelig commented 6 years ago

I stand corrected. It seems my school account has the same issue. screenshot 2018-03-02 at 1 58 12 pm

jbutrip commented 6 years ago

just installed on a Cloudready/Neverware Chromebook; same problem as above

Robclifton9 commented 6 years ago

Hi,

When do you expect this to be resolved, unfortunately can't use it as it is currently.

Thanks,

Rob

rooey commented 6 years ago

Been a bit busy of late. From what I can tell there are two separate issues causing this error.

  1. Seems to be related to the token expiration (and total failure of my attempt to use a refresh token) with the MS API
  2. I can not track it down; when performing various operations (copy, view, etc) this error appears - any debug / logs you guys can post on this one would be really helpful in tracking this fault down.

M.

cthetford commented 6 years ago

If you can tell me how to collect a log, I'll be happy to provide whatever I can. I am running chromeos in developer mode if that helps.

droz36 commented 6 years ago

I could be wrong here, but in chromeos-filesystem-onedrive/app/scripts/onedrive_client.js on line 173 you are not setting the new Refresh Token code. The line looks like this: OneDriveClient.prototype.setCookie(this.accesstoken, this.tokenexpiry)

But I think it should be this: OneDriveClient.prototype.setCookie(this.accesstoken, this.refreshtoken, this.tokenexpiry);

Based on https://docs.microsoft.com/en-us/onedrive/developer/rest-api/getting-started/msa-oauth doesn't the refreshToken change each time you request a new token?

droz36 commented 6 years ago

Ok, so I tested the change. It took me all day to get the application to build and to set up my own app id with Microsoft to test it and get it working, but it worked. Its been more than 5 minutes and I can still traverse folders in the Files app. No error message.

Should i make the change then create a pull request?

LSeelig commented 6 years ago

Thanks. Dure

Get Outlook for Androidhttps://aka.ms/ghei36


From: droz36 notifications@github.com Sent: Saturday, June 9, 2018 8:03:37 PM To: rooey/chromeos-filesystem-onedrive Cc: LordMethenor; Comment Subject: Re: [rooey/chromeos-filesystem-onedrive] OneDrive - An operation is taking longer than expected. Do you want to abort it? (#23)

Ok, so I tested the change. It took me all day to get the application to build and to set up my own app id with Microsoft to test it and get it working, but it worked. Its been more than 5 minutes and I can still traverse folders in the Files app. No error message.

Should i make the change then create a pull request?

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/rooey/chromeos-filesystem-onedrive/issues/23#issuecomment-396010939, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AjSXsVa9k76ID_WYKUC5LLnx2QXNBgeZks5t7HBpgaJpZM4SKB8a.

droz36 commented 6 years ago

I'd be happy to help troubleshoot this code and work on it overtime. I don't really know javascript that well, but I do enjoy learning and I love the idea of the extension.

Any idea when the next official release might be? I would be happy to help with builds too.

rooey commented 6 years ago

just now - thanks for your help ;)

droz36 commented 6 years ago

Is anyone else having an issue with the token disappearing after sleep?

rooey commented 6 years ago

That's a separate problem - I think the code for resuming an old connection is complete garbage...

droz36 commented 6 years ago

do you know the entry point for resuming? I'd be happy to take a look. I was wondering if maybe the cookie was getting destroyed when i put the os to sleep

I'm not great at troubleshooting this. I wonder if it would help to write more to the console log for debugging

wmjmd commented 6 years ago

Just got an HP Chromebook X2, running stable channel. I have the same problem trying to mount OneDrive- it initially mounts, then any attempt at using the files results in the barrage of error messages as described above. Is there anything I could do in the meantime to try to fix this?

rooey commented 6 years ago

@droz36 it's in onedrive_fs.js - the problem is; the whole area needs re-writing... take a look and you'll see what I mean... the mount is hard coded - i wanted to split it out so it's named after the actual volume being mounted (providing support for multiple accounts business & personal) - but we don't get that data until AFTER the mount - very frustrating.. you'll see the boat-load of commented-out debug I had in there in a dev build.

specifically: OneDriveFS.prototype.resume is where the magic is failing to happen - I'll bet that this is very similar to the problem you fixed but my brain is dead from looking at this stuff, I can no longer see clearly.

rooey commented 6 years ago

@wmjmd please see info here on how to report more useful details: https://github.com/rooey/chromeos-filesystem-onedrive/wiki/How-to-Capture-the-Console-Log-of-DevTools - we really need some good debug on this issue. Including the specific error message you are seeing.

rooey commented 6 years ago

@phillym

Do you still see this on the new version? Can you get me a fresh copy of the log?

Whenever File App is first opened the following error is observed in the 'File System for OneDrive' logs background.js:1227 Start: assignEventHandlers background.js:1306 End: assignEventHandlers _generated_background_page.html:1 Error in response to storage.get: TypeError: Cannot read property 'refreshToken' of undefined at OneDriveFS. (chrome-extension://jbfdfcehgafdbfpniaimfbfomafoadgo/background.js:1055:53)

wmjmd commented 6 years ago

Here is what I got after I tried to open up some old music folders about a minute after mounting OneDrive. Does this help?

Bill [Image]

Get Outlook for Androidhttps://aka.ms/ghei36


From: Michael Verdun Heath notifications@github.com Sent: Tuesday, June 19, 2018 12:27:53 PM To: rooey/chromeos-filesystem-onedrive Cc: wmjmd; Mention Subject: Re: [rooey/chromeos-filesystem-onedrive] OneDrive - An operation is taking longer than expected. Do you want to abort it? (#23)

@phillymhttps://nam01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fphillym&data=02%7C01%7C%7C620a11afda534a960b1b08d5d6019bed%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636650224745784806&sdata=L8G%2B1g9pwv5zk2XNkG4jeUpsALlFZ2kQpLaEK%2BmnE18%3D&reserved=0

Do you still see this on the new version? Can you get me a fresh copy of the log?

Whenever File App is first opened the following error is observed in the 'File System for OneDrive' logs background.js:1227 Start: assignEventHandlers background.js:1306 End: assignEventHandlers _generated_background_page.html:1 Error in response to storage.get: TypeError: Cannot read property 'refreshToken' of undefined at OneDriveFS. (chrome-extension://jbfdfcehgafdbfpniaimfbfomafoadgo/background.js:1055:53)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://nam01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Frooey%2Fchromeos-filesystem-onedrive%2Fissues%2F23%23issuecomment-398461520&data=02%7C01%7C%7C620a11afda534a960b1b08d5d6019bed%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636650224745784806&sdata=AV6p6xVTUTsLtmBpwtFuZMGyQ%2FAIqDECjqvvoOBdsqE%3D&reserved=0, or mute the threadhttps://nam01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAmhwZaCSljj_6HDWPClll-pVrufmjQ1Jks5t-SaJgaJpZM4SKB8a&data=02%7C01%7C%7C620a11afda534a960b1b08d5d6019bed%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636650224745784806&sdata=wm%2F5gUJSY7%2BHXrVHtR9wOzoWSg%2B4m63f5xvdEeZpkiE%3D&reserved=0.

rooey commented 6 years ago

@wmjmd Yeah - view your message on the website, it's garbled...

pamiller65 commented 6 years ago

Ok I added OneDrive as a file System from the Chrome webstore... like everyone else I am getting the same message that onedrive is taking longer than expected... I just want to remove this file system app from my chromebook.. How do I do that?

Thanks,

Paul

nonfiniscequi commented 6 years ago

I added Onedrive as a file System from che Chrome webstore...but I have the same issue "taking longer than expected"... what about a solution? Thank you in advance. VL

logan-markewich commented 6 years ago

I'm going to look it over when I can, but this seems helpful to compare to - > https://github.com/OneDrive/onedrive-explorer-js?files=1

logan-markewich commented 6 years ago

So after doing some testing, here's the only errors and warnings I am getting. That first error was generated right when I first installed/mounted, the rest just sporadically came in.

_generated_background_page.html:1 Error in response to storage.get: TypeError: Cannot read property 'refreshToken' of undefined at OneDriveFS.<anonymous> (chrome-extension://jbfdfcehgafdbfpniaimfbfomafoadgo/background.js:1055:53) at OneDriveFS.resume (chrome-extension://jbfdfcehgafdbfpniaimfbfomafoadgo/background.js:1050:34) at OneDriveFS.<anonymous> (chrome-extension://jbfdfcehgafdbfpniaimfbfomafoadgo/background.js:1214:22) Size specified, but not requested. Last modification time specified, but not requested. IsDirectory specified, but not requested. Name specified, but not requested. MIME type specified, but not requested.

Danmareno commented 6 years ago

Sir, you clearly have a nonfunctioning app could you please advise how we all stop this repetitive message "one drive is taking longer than expected" appearing either by showing how we uninstall (I have tried the obvious) I would be happy to pay for a working app but this is very disappointing.

logan-markewich commented 6 years ago

Find the app in the app drawer, right click, uninstall. Like every other app. That message won't stop until the code is fixed.

If it stops working I right click on the onedrive folder and click exit (do it twice), then remount the drive. Works fine after that.

It's not perfect, but it'll get there

Danmareno commented 6 years ago

thanks I will try that

On Sun, Aug 26, 2018 at 5:22 PM logan-markewich notifications@github.com wrote:

Find the app in the app drawer, right click, uninstall. Like every other app. That message won't stop until the code is fixed, although it well enough for me.

If it stops working I right click on the onedrive folder and click exit (do it twice), then remount the drive. Works fine after that.

It's not perfect, but it'll get there

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/rooey/chromeos-filesystem-onedrive/issues/23#issuecomment-416050649, or mute the thread https://github.com/notifications/unsubscribe-auth/AovOnjVwdGK--ctYWRww9U5dxnsdFRsWks5uUstRgaJpZM4SKB8a .

-- Managing Director Barnscroft of Devon Ltd

[image: --]

Steve Upperton [image: https://]about.me/steveupperton https://about.me/steveupperton?promo=email_sig

logan-markewich commented 6 years ago

@droz36 did you ever get any further? I'm starting to debug a bit now, just curious how far you got.

droz36 commented 6 years ago

My dog chewed through my chromebook power adapter. waiting on the new one to arrive. heh

LSeelig commented 6 years ago

That is the lamest excuse I have ever heard xD

rooey commented 6 years ago

Can anyone confirm that the "operation is taking longer than expected" annoyance went away with ChromeOS 69?

And no, I never figured out what was causing it.

The only issue i'm seeing now is with Token Expiry.

rooey commented 6 years ago

Crap - spoke too soon... Just got it again. bangs head against desk

wmjmd commented 6 years ago

This extension does not work with version 70 beta either

William Jantsch MD 233 South 6th St #2301 Philadelphia, PA 19106 740 507 7434 wmjantsch@hotmail.commailto:wmjantsch@hotmail.com


From: Michael Verdun Heath notifications@github.com Sent: Tuesday, September 25, 2018 8:22 AM To: rooey/chromeos-filesystem-onedrive Cc: wmjmd; Mention Subject: Re: [rooey/chromeos-filesystem-onedrive] OneDrive - An operation is taking longer than expected. Do you want to abort it? (#23)

Crap - spoke too soon... Just got it again. bangs head against desk

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Frooey%2Fchromeos-filesystem-onedrive%2Fissues%2F23%23issuecomment-424320671&data=02%7C01%7C%7C8c553050f48a4124caba08d622e17f70%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636734749227022672&sdata=irPXsNkX2y8EY6ubxv6gKZ40erkoZAaieemq3y3ji1Y%3D&reserved=0, or mute the threadhttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAmhwZZljQbGLPk2_6x7w3f3JfW88DV6Tks5ueh_pgaJpZM4SKB8a&data=02%7C01%7C%7C8c553050f48a4124caba08d622e17f70%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636734749227022672&sdata=%2FEtMNC2g2YUyA7UyRCL%2FehRsV1%2Bl%2BBfSNxidlTnbtPo%3D&reserved=0.

gdschut commented 6 years ago

Just updated to Version 69.0.3497.95 (Official Build) (32-bit), and now it works!

marcusvanwely commented 6 years ago

In version 69.0.3497.95 (64-bit) error still occurs

asumos commented 5 years ago

confirmed still exists in latest version of ChromeOS

full-bars commented 5 years ago

still having this issue in latest chromeOS Version 70.0.3538.110 (Official Build) (64-bit)

fourleggedostrich commented 5 years ago

Is there any news on this? Is sit still being developed? It's close to unusable in its current condition.

asumos commented 5 years ago

Is there any news on this? Is sit still being developed? It's close to unusable in its current condition.

this has been an issue for nearly a year now. so i would assume not

larosabob commented 5 years ago

Any word on resolving this issue? It works once in a while then stops working with the same message.

Sorry forgot to add Version 71.0.3578.94 (Official Build) (32-bit)

LSeelig commented 5 years ago

without this bug, I could do away with my googledrive completely. would make some stuff I do a lot easier. No need to ferry folders or use bad, slow, freemium drivesyncs. The only one I could find that was suitable, Multcloud, forces me to go through an arduous log in process to sync the drives and operates like a snail.

full-bars commented 5 years ago

Pretty much given up on getting this fixed at this point

petermead83 commented 5 years ago

Is there any update on this issue? Have had a read through some of the Microsoft questions and answers but Microsoft are saying its a Chrome issue.

Do we know when this might be fixed and working again?

rooey commented 5 years ago

To be honest, i've never figured out what's causing it; and like most of you, I myself use the force exit and re-mount approach to keep it working. I'm not entirely unconvinced that it's not a chromeos issue; that said, i'm also not overly convinced that the OneDriveFS.resume function works properly either... If i had more time...

rooey commented 5 years ago

without this bug, I could do away with my googledrive completely. would make some stuff I do a lot easier. No need to ferry folders or use bad, slow, freemium drivesyncs. The only one I could find that was suitable, Multcloud, forces me to go through an arduous log in process to sync the drives and operates like a snail.

Me too... lol does that make me terrible?

rooey commented 5 years ago

32 addresses this bug

gjlamb commented 5 years ago

Also having this problem and am working on authentication. Can I ask is there anyone who files app is working for?

Looking through the posts above regarding token refresh, I'm having other issues where refresh token is a problem. We are currently in a hybrid setup where we are syncing from on premise AD to AAD. Because of domain setup when starting hybrid config, the sync was setup for 'alternate login' where mail (primarysmtpaddress) was synced to UPN in AAD. It appears that this is a problem as it stops computers receiving a refresh token. I'm in the process of modifying sync to be UPN to UPN.

Will advise if this resolves anything for me.