rooey / chromeos-filesystem-onedrive

This project provides a OneDrive FileSystem mount for ChromeOS
http://onedrivefs.justmichael.uk/
BSD 3-Clause "New" or "Revised" License
36 stars 20 forks source link

Rewrite onedrive_client.js with correct API calls #31

Closed rooey closed 4 years ago

rooey commented 5 years ago

onedrive_client.js updates need to be fixed with the correct API URLs and calls for OneDrive.

droz36 commented 5 years ago

Do you have any time coming up to work on rewriting this app? I would like to help with it.

rooey commented 5 years ago

I already did. I merged the changes to master last night. I'm having an issue with refresh after a copy from one directory to another and also thumbnail previews, otherwise it's working well.

rooey commented 5 years ago

Oh I haven't implemented refresh token yet either for persistent connections, so it unmounts automatically on expiry at the moment. Do you have your own valid API key?

droz36 commented 5 years ago

I had an API key before. I haven't really looked at the code in a long time, but I can always set one up again if I need to.

rooey commented 5 years ago

Excellent. An additional permission is needed now for user.read other than that, it should be same as before

rooey commented 5 years ago

Implemented in 7e21d8cb8a6800e1a979ebf096bcc91fbf7e4188

droz36 commented 5 years ago

i keep getting a failed to mount object. did I do something wrong?

rooey commented 5 years ago

Did you add the user.read to your ms graph API key?

rooey commented 5 years ago

or maybe i screwed up the build i checked in... hang on...

rooey commented 5 years ago

seems ok - don't forget to add your API secret

droz36 commented 5 years ago

Yes. I did

droz36 commented 5 years ago

What do you put in redirect url?

rooey commented 5 years ago

message on slack? https://join.slack.com/t/chromiumdev/shared_invite/enQtMzM3NjYwNjI0MDM4LTk2NjEyYTIxODk1MDYxMmNjNWYzMGMxZGVhMDNhY2I1ZjBhMjdlYTg0MTg4ZGE0OTQ0ZmYwNTRiMGJlYzVjOTE

rooey commented 4 years ago

addressed in 044fb10