rooey / chromeos-filesystem-onedrive

This project provides a OneDrive FileSystem mount for ChromeOS
http://onedrivefs.justmichael.uk/
BSD 3-Clause "New" or "Revised" License
36 stars 23 forks source link

Lint error: 'options' is not defined #49

Closed iamacarpet closed 4 years ago

iamacarpet commented 4 years ago

Describe the bug

When building the latest version of master, gulp fails with a lint error.

[11:02:32] Using gulpfile /****/chromeos-filesystem-onedrive/gulpfile.js
[11:02:32] Starting 'default'...
[11:02:32] Starting 'clean'...
[11:02:32] Finished 'clean' after 5.07 ms
[11:02:32] Starting 'lint'...
[11:02:33]
/****/chromeos-filesystem-onedrive/src/scripts/onedrive_client.js
  623:13  error  'options' is not defined  no-undef
  624:42  error  'options' is not defined  no-undef
  625:29  error  'options' is not defined  no-undef

✖ 3 problems (3 errors, 0 warnings)

[11:02:33] 'lint' errored after 712 ms
[11:02:33] ESLintError in plugin "gulp-eslint"
Message:
    Failed with 3 errors
Details:
    domainEmitter: [object Object]
    domain: [object Object]
    domainThrown: false

[11:02:33] 'default' errored after 721 ms

To Reproduce Steps to reproduce the behaviour:

  1. Check out the latest version of master.
  2. npm install
  3. gulp

Additional Notes If you disable the lint step in the gulp file, it does build & run ok (sort of).

Looking at the lines in the file it is referring to, for the first one in the file at-least, the options object hasn't been initialised at the point you are setting a value inside it; is it just a case of initialising it first, or was a pre-filled object supposed to be passed?