csi: add setup for external mode for subvolume cleanup

rook / kubectl-rook-ceph

Krew plugin to run kubectl commands with rook-ceph

Apache License 2.0

74 stars 26 forks source link

Closed yati1998 closed 3 months ago

yati1998 commented 3 months ago

This commit adds extra setup that if required for subvolume cleanup incase of external mode

yati1998 commented 3 months ago

@yati1998 we cannot add downstream specific things to the upstream tool which is in Rook repo.

Got it, we need to have additional changes in odf-cli for downstream. Will update the PR here.

yati1998 commented 3 months ago

@nixpanic please do add your reviews as well, if any.

subhamkrai commented 3 months ago

@nixpanic please do add your reviews as well, if any.

going ahead with the PR, we can follow up later if have more comments. Thanks