mon: remove unnecessary arg `public bind addr`

rook / kubectl-rook-ceph

Krew plugin to run kubectl commands with rook-ceph

Apache License 2.0

81 stars 27 forks source link

Closed shay1760 closed 6 months ago

shay1760 commented 6 months ago

since ceph reef, monMapArg --public-bind-addr is not required anymore.

Description of your changes:

Which issue is resolved by this Pull Request: Resolves #185

Checklist:

[ ] Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
[ ] Reviewed the developer guide on Submitting a Pull Request
[ ] CI tests has been updated, if necessary.
[ ] Documentation has been updated, if necessary.
[ ] Unit tests have been added, if necessary.

travisn commented 6 months ago

Quincy is still supported in upstream Rook, so we may still need this argument for now...

subhamkrai commented 6 months ago

Quincy is still supported in upstream Rook, so we may still need this argument for now...

travisn commented 6 months ago

Quincy is still supported in upstream Rook, so we may still need this argument for now...

273 I tested here it is working

Ok great to hear it also works with Quincy