search

rook / kubectl-rook-ceph

Krew plugin to run kubectl commands with rook-ceph
Apache License 2.0
80 stars 27 forks source link

Pending cephfs stale cleanup #272

Open Madhu-1 opened 6 months ago

Madhu-1 commented 6 months ago

This tracks the pending work for cephfs stale volumes

@yati1998 above cases are already covered or yet to be covered? Do we have a tracker for it? (i tried to find one but not able to)

yati1998 commented 6 months ago
  1. In the case of pending clones, we won't have subvolumes created at the backend (as per my testing) and hence, I don't think we need to bother about the pending clones. Please correct me if I am wrong.
  2. How do we consider a volume snapshot as stale? According to my plan, we are restoring the snapshots so that they can be used to restore the volumes if required.
  3. NFS csi drivers are covered with the same logic as a normal csi driver, just an additional step for cleanup of its extra configuration stored needs to be done, we can use this issue itself to track that.
  4. Not sure what has to be done for ROX PVC separately!!
Madhu-1 commented 6 months ago
  1. In the case of pending clones, we won't have subvolumes created at the backend (as per my testing) and hence, I don't think we need to bother about the pending clones. Please correct me if I am wrong.

Yes it will be created when we create PVC from PVC/Snapshot, please check on this one,

  1. How do we consider a volume snapshot as stale? According to my plan, we are restoring the snapshots so that they can be used to restore the volumes if required.

Anyone can delete the kubernetes yamls and the backend snapshot might not get deleted.

  1. NFS csi drivers are covered with the same logic as a normal csi driver, just an additional step for cleanup of its extra configuration stored needs to be done, we can use this issue itself to track that. 👍🏻
  2. Not sure what has to be done for ROX PVC separately!!

This also need to be considered where Ref counters/backend snapshot etc need to be checked and cleaned up if required.

yati1998 commented 2 months ago

Except the ROX pvc, rest all cases are being covered.

yati1998 commented 2 months ago

https://github.com/rook/kubectl-rook-ceph/pull/307 https://github.com/rook/kubectl-rook-ceph/pull/311 https://github.com/rook/kubectl-rook-ceph/pull/312