rook / nfs

Rook storage provider for NFS
Apache License 2.0
31 stars 10 forks source link

Support client access control for NFS volumes #5

Closed rohan47 closed 3 years ago

rohan47 commented 6 years ago

Is this a bug report or feature request?

What should the feature do: Currently, the NFS export can be accessed by any client. This feature will restrict volume access to specified clients and also it will implement squash and access control per client/clients as per the NFS CRD design doc. An example of this can be found here

rohan47 commented 6 years ago

nfsservers.nfs.rook.io type already supports the allowed clients https://github.com/rook/rook/blob/master/pkg/apis/nfs.rook.io/v1alpha1/types.go#L84

tsullens commented 6 years ago

I can do this if you want to assign it to me.

rohan47 commented 6 years ago

@tsullens sure, go ahead.

sourabh1031 commented 5 years ago

@rohan47 can i work on it

rohan47 commented 5 years ago

@sourabh1031 there is a PR by @tsullens for this https://github.com/rook/rook/pull/2315. We haven't seen any activity from him for a month. @jbw976 what do you suggest?

tsullens commented 5 years ago

@sourabh1031 @rohan47 I apologize as I've gotten a bit busy and never finished this up. The PR as-is adds this functionality but lacks an appropriate integration test for it. I'm more than fine with @sourabh1031 finishing up the PR and maybe we should have a separate issue for the integration test?

jbw976 commented 5 years ago

Added a comment to the PR @tsullens @rohan47

https://github.com/rook/rook/pull/2315#issuecomment-485858273

stale[bot] commented 5 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] commented 5 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] commented 5 years ago

This issue has been automatically closed due to inactivity. Please re-open if this still requires investigation.