Closed galexrt closed 4 years ago
@galexrt LGTM. Were you able to validate it locally?
@travisn Yes, I ran it locally with make run
(that is why the first commit "locks" the Jekyll docker image version so the current Gemfile works).
I saw the noindex
meta tag appearing on all docs pages for master
and non currentVersion
releases.
@travisn I just checked the pages, it works as tested and expected :smile:
nice @galexrt, thanks for making this improvement quickly! 💪
Awesome! Thanks for the quick fix
make: added jekyll docker image variable
Use Jekyll image 3.7 due to the older bundler version used in this repository.
Signed-off-by: Alexander Trost galexrt@googlemail.com
layouts: put meta noindex for non latester version docs
Put the meta noindex tag for non latest version docs pages. This should prevent master and non latest / current version docs to not appear in search results anymore.
Resolves #91
Signed-off-by: Alexander Trost galexrt@googlemail.com
The liquid template changes are probably not made in the best way, any feedback on how to handle this better is welcome!