Closed pando85 closed 4 years ago
Edited: I misunderstood.
Ok, I will change it.:)
@pando85 Could you change your PR to implement the
help
target as in the main repository, see https://github.com/rook/rook/blob/master/Makefile#L181-L186 For this repo theHELPTEXT
part isn't needed.
Done
@pando85 No problem! Thank you for making the changes!
The DCO check is failing now, please squash your two commits into one and make sure the DCO sign off is applied correctly (see https://github.com/rook/rook/blob/master/CONTRIBUTING.md#certificate-of-origin). (your first commit has the correct sign off on it, so squashing and removing the second commit's message should fix it)
Here we go!
@pando85 Could you change your PR to implement the
help
target as in the main repository, see https://github.com/rook/rook/blob/master/Makefile#L181-L186 For this repo theHELPTEXT
part isn't needed.