search

rook / rook.github.io

Apache License 2.0
25 stars 31 forks source link

Add help command to makefile and .PHONY #93

Closed pando85 closed 4 years ago

galexrt commented 4 years ago

@pando85 Could you change your PR to implement the help target as in the main repository, see https://github.com/rook/rook/blob/master/Makefile#L181-L186 For this repo the HELPTEXT part isn't needed.

pando85 commented 4 years ago

Edited: I misunderstood.

Ok, I will change it.:)

pando85 commented 4 years ago

@pando85 Could you change your PR to implement the help target as in the main repository, see https://github.com/rook/rook/blob/master/Makefile#L181-L186 For this repo the HELPTEXT part isn't needed.

Done

galexrt commented 4 years ago

@pando85 No problem! Thank you for making the changes!

The DCO check is failing now, please squash your two commits into one and make sure the DCO sign off is applied correctly (see https://github.com/rook/rook/blob/master/CONTRIBUTING.md#certificate-of-origin). (your first commit has the correct sign off on it, so squashing and removing the second commit's message should fix it)

pando85 commented 4 years ago

Here we go!