rook / rook

Storage Orchestration for Kubernetes
https://rook.io
Apache License 2.0
11.98k stars 2.64k forks source link

operator: support custom dashboard service labels and annotations #14115

Closed sfackler closed 3 weeks ago

sfackler commented 3 weeks ago

Unlike other components, the Ceph dashboard Service object could not be configured with custom labels and annotations. This can be useful when integrating Rook into a cluster with custom controllers similarly to how the RGW service is customized.

Issue resolved by this Pull Request: Resolves #14111

Checklist:

Let me know if you'd like a unit test!

sfackler commented 3 weeks ago

I think the integration test failures are unrelated?

Error: UPGRADE FAILED: error validating "": error validating data: ValidationError(CephCluster.spec): unknown field "upgradeOSDRequiresHealthyPGs" in io.rook.ceph.v1.CephCluster.spec , err -> exit status 1

sfackler commented 3 weeks ago

Updated!