core: fix function names in comment

rook / rook

Storage Orchestration for Kubernetes

https://rook.io

Apache License 2.0

11.98k stars 2.64k forks source link

core: fix function names in comment #14124

Closed findmyhappy closed 3 weeks ago

findmyhappy commented 3 weeks ago

Checklist:

[ ] Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
[ ] Reviewed the developer guide on Submitting a Pull Request
[ ] Pending release notes updated with breaking and/or notable changes for the next minor release.
[ ] Documentation has been updated, if necessary.
[ ] Unit tests have been added, if necessary.
[ ] Integration tests have been added, if necessary.

Madhu-1 commented 3 weeks ago

Error: You have commit messages with errors ⧗ input: pkg: fix function names in comment Signed-off-by: findmyhappy findhappy@sohu.com ✖ type must be one of [block, bot, build, cephfsmirror, ci, core, cosi, csi, doc, docs, exporter, external, file, helm, k8sutil, manifest, mds, mgr, mon, monitoring, multus, network, nfs, object, operator, osd, pool, rbdmirror, rgw, security, subvolumegroup, namespace, test, tests] [type-enum]

@findmyhappy pkg is not as expected, please use core in commit message

findmyhappy commented 3 weeks ago

Error: You have commit messages with errors ⧗ input: pkg: fix function names in comment Signed-off-by: findmyhappy findhappy@sohu.com ✖ type must be one of [block, bot, build, cephfsmirror, ci, core, cosi, csi, doc, docs, exporter, external, file, helm, k8sutil, manifest, mds, mgr, mon, monitoring, multus, network, nfs, object, operator, osd, pool, rbdmirror, rgw, security, subvolumegroup, namespace, test, tests] [type-enum]

@findmyhappy pkg is not as expected, please use core in commit message

Thanks! Modified

Madhu-1 commented 3 weeks ago

@findmyhappy please update commit message as per https://github.com/rook/rook/blob/master/Documentation/Contributing/development-flow.md#commit-structure

findmyhappy commented 3 weeks ago

@findmyhappy please update commit message as per https://github.com/rook/rook/blob/master/Documentation/Contributing/development-flow.md#commit-structure

I think it's in line now. Sorry, do you mean I need to describe the changes in detail in the commit message?

subhamkrai commented 3 weeks ago

@findmyhappy please update commit message as per https://github.com/rook/rook/blob/master/Documentation/Contributing/development-flow.md#commit-structure

I think it's in line now. Sorry, do you mean I need to describe the changes in detail in the commit message?

yes @findmyhappy we give small brief about change in commit message description

findmyhappy commented 3 weeks ago

@findmyhappy please update commit message as per https://github.com/rook/rook/blob/master/Documentation/Contributing/development-flow.md#commit-structure

I think it's in line now. Sorry, do you mean I need to describe the changes in detail in the commit message?

yes @findmyhappy we give small brief about change in commit message description

Thanks!

Added. Please review again.