Closed parth-gr closed 3 weeks ago
Testing Before fix
2024-04-24 11:36:17.894810 E | ceph-cluster-controller: failed to reconcile CephCluster "rook-ceph/my-cluster". failed to reconcile cluster "my-cluster": failed to configure local ceph cluster: failed to create cluster: failed to start ceph monitors: failed to initialize ceph cluster info: failed to save mons: failed to update csi cluster config: waiting for CSI config map to be created: configmaps "rook-ceph-csi-config" not found
After fix:
2024-04-24 11:40:14.084815 I | op-mon: saved mon endpoints to config map map[csi-cluster-config-json:[{"clusterID":"rook-ceph","monitors":["10.110.93.212:6789"],"cephFS":{"netNamespaceFilePath":"","subvolumeGroup":"","kernelMountOptions":"","fuseMountOptions":""},"rbd":{"netNamespaceFilePath":"","radosNamespace":""},"nfs":{"netNamespaceFilePath":""},"readAffinity":{"enabled":false,"crushLocationLabels":null},"namespace":""}] data:a=10.110.93.212:6789 mapping:{"node":{"a":{"Name":"minikube","Hostname":"minikube","Address":"192.168.39.204"}}} maxMonId:0 outOfQuorum:]
LGTM, https://github.com/parth-gr/rook/blob/2e7398592498b0c9df184f41445190bcf76f8f83/pkg/operator/ceph/csi/cluster_config.go#L259 will be logged many times when the controller reconciles even if the csi is disabled, we can do logging only when create.
updated, Thanks!
Creating a cluster never succeeds if CSI driver is disabled So to fix that we need to always create the csi configmap
closes: https://github.com/rook/rook/issues/14123
Checklist: