osd: limit storageClassDeviceSets to 63 chars

[subhamkrai]

there are some cases where storageClassDeviceSets length are more 63 chars and osd provisioned failed due to this. with error

 failed to run osd provisioning job for PVC "ocs-deviceset-*-local-volume-storageclass-0-data-*": Job.batch "rook-ceph-osd-prepare-*" is invalid: [spec.template.spec.volumes[10].name: Invalid value: "ocs-deviceset-*-local-volume-storageclass-0-data-*": must be no more than 63 characters, spec.template.spec.containers[0].volumeMounts[9].name: Not found: "ocs-deviceset-*-local-volume-storageclass-0-data-*",

Using x-validator to limit the maxLength to 63 chars.

Checklist:

• [ ] Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
• [ ] Reviewed the developer guide on Submitting a Pull Request
• [ ] Pending release notes updated with breaking and/or notable changes for the next minor release.
• [ ] Documentation has been updated, if necessary.
• [ ] Unit tests have been added, if necessary.
• [ ] Integration tests have been added, if necessary.

[subhamkrai]

testing result

ka cluster-on-pvc.yaml 
The CephCluster "rook-ceph" is invalid: 
* spec.storage.storageClassDeviceSets[0].name: Too long: may not be longer than 63
* <nil>: Invalid value: "null": some validation rules were not checked because the object was invalid; correct the existing errors to complete validation

[anthonyeleven]

Is a "deviceset" a Rook-internal thing?

[subhamkrai]

Is a "deviceset" a Rook-internal thing?

@anthonyeleven yess

[travisn]

@anthonyeleven For an example of the storageClassDeviceSets, see the PVC-based clusters.