search

rook / rook

Storage Orchestration for Kubernetes
https://rook.io
Apache License 2.0
11.98k stars 2.64k forks source link

Support options to always use LVM mode even if the disk is allow for raw mode #14151

Open chenyuanrun opened 2 weeks ago

chenyuanrun commented 2 weeks ago

In allowRawMode@pkg/daemon/ceph/osd/volume.go , rook prefer raw mode for disk if it is allowed. In some case we want always use lvm mode to prepare osd (as the name of disk may chang across reboot), can we add a option (something like preferLvm) and use lvm mode if this option is provided?

Is this a bug report or feature request?

What should the feature do:

What is use case behind this feature:

Environment:

travisn commented 2 weeks ago

If the disk is labeled, the raw mode is expected to be stable for OSDs even if the disks are renamed on reboot. We wanted to avoid LVM mode because there were challenges with stability with the LVs and proper provisioning and shutdown. Given our negative experiences with LVM in the past, I would be concerned with enabling LVM mode unless it's absolutely necessary. @satoru-takeuchi Additional thoughts?

satoru-takeuchi commented 1 week ago

@travisn I also hesitate to add this feature. LVM mode sometimes has pitfalls in container environment.