search

rook / rook

Storage Orchestration for Kubernetes
https://rook.io
Apache License 2.0
12.42k stars 2.69k forks source link

rook-toolbox from release-1.15 uses ceph v18.x instead of v19.x #15040

Open nirs opened 5 days ago

nirs commented 5 days ago

Is this a bug report or feature request?

Deviation from expected behavior: rook release 1.15 uses quay.io/ceph/ceph:v19, but rook-toolbox uses quay.io/ceph/ceph:v18.2.4

Expected behavior: Using same ceph magor version for all examples.

How to reproduce it (minimal and precise):

  1. Deploy cluster from: https://raw.githubusercontent.com/rook/rook/release-1.15/deploy/examples/cluster-test.yaml

  2. Deploy rook-toolbox from: https://raw.githubusercontent.com/rook/rook/release-1.15/deploy/examples/toolbox.yaml

travisn commented 5 days ago

cluster-test.yaml is only for testing purposes, and sometimes has the latest ceph version, which is different from the default production version in all of the other examples. In v1.15 we are going to keep Ceph v18.2.x as the default ceph version, while in the upcoming v1.16 we will set v19.2.x as the default version. So this will be updated soon, but not backported to v1.15.

nirs commented 5 days ago

So we need to update the toolbox image for testing? We test release-1.15 and always install the toolbox.

Maybe we can have toolbox-test.yaml matching cluster-test.yaml?

travisn commented 5 days ago

In the next few days we should have updated all the production examples on v19 as we prepare for Rook v1.16. So in the 1.16 branch toolbox-test.yaml would be the same as toolbox.yaml. For now can you just replace the image when you deploy from the 1.15 branch? The examples are intended to be modified depending on different environments.