rookLab / react-component-caching

Speedier server-side rendering with component caching in React 16
388 stars 26 forks source link

Doesn't work with Context API #46

Open stevefan1999-personal opened 6 years ago

stevefan1999-personal commented 6 years ago
{ '$$typeof': Symbol(react.element),
  type: // notice here
   { '$$typeof': Symbol(react.context),
     _calculateChangedBits: null,
     _defaultValue:
      { color: undefined,
        size: undefined,
        className: undefined,
        style: undefined,
        attr: undefined },
     _currentValue:
      { color: undefined,
        size: undefined,
        className: undefined,
        style: undefined,
        attr: undefined },
     _currentValue2:
      { color: undefined,
        size: undefined,
        className: undefined,
        style: undefined,
        attr: undefined },
     _changedBits: 0,
     _changedBits2: 0,
     Provider: { '$$typeof': Symbol(react.provider), _context: [Circular] },
     Consumer: [Circular],
     _currentRenderer: null,
     _currentRenderer2: null },
  key: null,
  ref: null,
  props: { children: [Function] },
  _owner: null,
  _store: {} }
TypeError: element.type.toLowerCase is not a function
    at ReactDOMServerRenderer.renderDOM (<REDACTED>\node_modules\react-component-caching\development.js:2998:32)
    at ReactDOMServerRenderer.render (<REDACTED>\node_modules\react-component-caching\development.js:2987:25)
    at ReactDOMServerRenderer.read (<REDACTED>\node_modules\react-component-caching\development.js:2845:25)
    at renderToString (<REDACTED>\node_modules\react-component-caching\development.js:3309:35)
    at _callee$ (<REDACTED>\build\webpack:\src\server.tsx:83:1)
    at tryCatch (<REDACTED>\node_modules\babel-runtime\node_modules\regenerator-runtime\runtime.js:62:40)
    at Generator.invoke [as _invoke] (<REDACTED>\node_modules\babel-runtime\node_modules\regenerator-runtime\runtime.js:296:22)
    at Generator.prototype.(anonymous function) [as next] (<REDACTED>\node_modules\babel-runtime\node_modules\regenerator-runtime\runtime.js:114:21)
    at step (<REDACTED>\node_modules\babel-runtime\helpers\asyncToGenerator.js:17:30)
    at <REDACTED>\node_modules\babel-runtime\helpers\asyncToGenerator.js:28:13
anagami commented 5 years ago

Hi! have you any plans for support Context API? looks like only your library support React 16, all other similar libs works with React 15 file system and incompatible with 16 version

ScriptedAlchemy commented 5 years ago

@DianeRossiter aside from the fact that your rant is near unreadable. I’m still not sure who you are actually targeting the message towards.

This is an open-source software forum. Personal issues, not the right place for that.

Engineers aren’t looking to read these posts. Software is separate from people - if someone has a issue with a person, that’s not really the fault of the open-source software. Multiple contributors maintain these projects, authors come and go.

Social media/reddit is a better place to voice these opinions and get feedback. Software engineers.. not so much.

Whatever is going on, it sounds intense and I do hope you find a support network & that the issues get resolved.

Posting comments like these do more damage to the software which makes it harder to implement these tools in corporate environments. Which means the users stand less chance of being able to improve their on projects.

stevefan1999-personal commented 5 years ago

@ScriptedAlchemy No man just straight out report to GitHub support and sort out the matter by them.

ScriptedAlchemy commented 5 years ago

Can’t report on my phone, but will do when on a machine.

Besides, I’d rather uphold OSS standards and hopefully give the user some clarity of how etiquette here works