search

rookie0 / nextcloud-sharing-path

🌩 Nextcloud app to enhance files sharing to be accessed by stored path, can be used as CDN origin.
GNU Affero General Public License v3.0
47 stars 11 forks source link

Make it default to disabled #26

Closed jsalatiel closed 3 years ago

jsalatiel commented 3 years ago

Please make it default to disabled in settings. That would improve security a lot since only power users and those who knew what sharingpath is would enable that setting.

rookie0 commented 3 years ago

Fixed in 0.3.0

sushibear commented 3 years ago

Hey... thanks for this great plugin but I don't agree with this change completely. Wouldn't it be possible to make this feature either way.. like the admin can force this to be on for all as default but each user can turn it off if he likes?

We would like this to be on for every new user we create using the Nextcloud API and since Apps can not be configured that way, we have no chance to do this, unless we would create a fork, which I think is not the way to go.

Regards

rookie0 commented 3 years ago

Maybe add an admin setting Default enable sharingpath, and this may go with #16 which i intend to add an admin setting Default sharing directory. What do u think? @sushibear

sushibear commented 3 years ago

Maybe add an admin setting Default enable sharingpath, and this may go with #16 which i intend to add an admin setting Default sharing directory.

Hey.. thanks for reopening this ticket and looking into this! I think Default enable sharingpath is exactly what we need even though I don't know what Default sharing directory would look like. I mean the current path is like: https://mydomain/apps/sharingpath/username/shared/folder/filename.png What would the default path look like?

Regards

rookie0 commented 3 years ago

Now you must share the file first before you can access it by sharingpath, the Default sharing directory is a setting which you can set a specific folder that the files in the folder can be accessed by sharingpath no matter you shared or not.

sushibear commented 3 years ago

Now you must share the file first before you can access it by sharingpath, the Default sharing directory is a setting which you can set a specific folder that the files in the folder can be accessed by sharingpath no matter you shared or not.

I understand.. hmmm.. but that would be another feature beside the Default enable sharing by the admin right? Because I think we might could use both features actually. :) ;)

rookie0 commented 3 years ago

Yeah, will done in 2020. 😄

sushibear commented 3 years ago

Thanks man! You Rock!

rookie0 commented 3 years ago

@sushibear v0.4.0 - nightly Please take a look.

sushibear commented 3 years ago

@rookie0 looking great man!! Good work!!