Fix Vue.js functionality due to malformed public-url in Windows

room-js / chrome-extension-ts-starter

Chrome Extension starter built with TypeScript

https://www.youtube.com/watch?v=01vp9cYbQus

MIT License

87 stars 27 forks source link

Fix Vue.js functionality due to malformed public-url in Windows #1

Closed CounterPly closed 4 years ago

CounterPly commented 4 years ago

The current project builds flawlessly in Mac/Linux, but loses Vue.js functionality while executing the build in Windows. The apostrophes present in the public-url in package.json are encoded incorrectly as "%27" while building in Windows and thus invalidate the resulting url. These apostrophes are unnecessary and can be safely removed without affecting the build process in any OS.

yurist38 commented 4 years ago

Thanks for the PR @CounterPly ! That's right!