search

roomkey / lein-v

Drive leiningen project version from git instead of the other way around
48 stars 11 forks source link

anchored hook fails silently during deploy #17

Open rymndhng opened 6 years ago

rymndhng commented 6 years ago

This is a minor quirk that makes monitoring deploy automation tricky. I noticed that when the anchoring message shows up, it doesn't return a non-zero exit code -- so for example, doing a release in jenkins may fail silently.

I think this would be related to this line? https://github.com/roomkey/lein-v/blob/master/src/leiningen/v.clj#L75-L80

cch1 commented 6 years ago

I understand the issue. An approach might be to invoke leingingen.core.main/abort with the message instead of just logging it. But I'll need to consider backwards compatibility. Might I ask that you submit a PR?

cch1 commented 6 years ago

Stand by... I've got a resolution.

cch1 commented 6 years ago

Can you install and test the version on the branch 17-abort-from-assert-anchored and confirm it solves your problem and does not introduce any new problems?

rymndhng commented 6 years ago

I gave it a spin. I noticed that when assert-anchored fails, the subprocess does not exit. I'm uncertain why this is the case because I don't think I have profiles set 🤔