Open kkolotyuk opened 7 years ago
Good point. This issue could really benefit from a shared specs, as discussed earlier right?
It's still depends on each supplier implementation, some of them
another
I don't have idea how to create shared spec for all the suppliers.
But I have a suggestion how we can prevent purging all the properties: before purge we should check if start
method was called at least once, if no - don't run the purge.
Currently I see that some calls of metadata workers can even not create sync process in DB. For example SAW sync:
My position is that every run of worker should leave something after it (for example successful/unsuccessful sync_process record in DB). So I wanted to make it mandatory to call
sync.finish!
for all wokers, but we also shouldn't forget to callskip_purge
in some error cases, otherwise we can purge all the properties((((Here how I would fix the SAW's worker:
Please let me know what do you think about this thought.