Closed sharipov-ru closed 7 years ago
PR looks fine. About specs: may be this example can help you https://github.com/roomorama/concierge/blob/master/spec/web/views/suppliers/show_spec.rb#L18
@kkolotyuk Yes, it was exactly what I was looking for! Added specs now, please review again guys.
:+1:
LGTM. But checks have failed.
@kkolotyuk it's something wrong on circleci. I'll push changelog to force it to rebuild again
:+1:
Fix for #571
No specs for now (there is something wrong in our specs when rendering partial templates from inside specs, possibly bug in hanami, I'll investigate later)