Do not try to access nil variable (fixes #571)

roomorama / concierge

Roomorama supplier integrations - webhook providers and property synchronisation

https://concierge-web.roomorama.com

3 stars 0 forks source link

Do not try to access nil variable (fixes #571) #575

Closed sharipov-ru closed 7 years ago

sharipov-ru commented 7 years ago

Fix for #571

No specs for now (there is something wrong in our specs when rendering partial templates from inside specs, possibly bug in hanami, I'll investigate later)

kkolotyuk commented 7 years ago

PR looks fine. About specs: may be this example can help you https://github.com/roomorama/concierge/blob/master/spec/web/views/suppliers/show_spec.rb#L18

sharipov-ru commented 7 years ago

@kkolotyuk Yes, it was exactly what I was looking for! Added specs now, please review again guys.

keang commented 7 years ago

:+1:

kkolotyuk commented 7 years ago

LGTM. But checks have failed.

sharipov-ru commented 7 years ago

@kkolotyuk it's something wrong on circleci. I'll push changelog to force it to rebuild again

kkolotyuk commented 7 years ago

:+1: