Ensure that parsable JSON is read from the socket by using a delimiter rather than assuming that messages are complete

roopesh / ad-qolsys

AppDaemon app for Qolsys IQ Panel 2

MIT License

22 stars 10 forks source link

Ensure that parsable JSON is read from the socket by using a delimiter rather than assuming that messages are complete #20

Closed Pablo1 closed 2 years ago

Pablo1 commented 2 years ago

Ensure that parsable JSON is read from the socket by using a delimiter rather than assuming that messages are complete

lesykm commented 2 years ago

@roopesh will you have time to look at open PRs? Thanks!

roopesh commented 2 years ago

@Pablo1 has this been tested by anyone with many devices to see what happens when there are large responses?

Pablo1 commented 2 years ago

@roopesh - I'm not sure if anyone else tried out my changes but I'll go take a look at the Home Assistant forums and see. I have 65 devices so I've definitely tested it but one person testing it isn't sufficient. I still get some issues but they seem to be related to the Panel's use of iptables but I can't be 100% certain.