search

roopesh / ad-qolsys

AppDaemon app for Qolsys IQ Panel 2
MIT License
22 stars 10 forks source link

Fix MQTT Discovery by defining a default/catch-all binary_sensor device_class #23

Open jsb5151 opened 2 years ago

jsb5151 commented 2 years ago
  1. catch-all for unspecified device class mappings
  2. remove unnecessary version_key and source_key payloads from arming command
roopesh commented 2 years ago

@jsb5151 Can you look at the questions I asked?

BShurilla commented 2 years ago

I manually applied the changed on this PR to my install, but I still have devices showing not getting classed right - Specifically Key Fob, Spare Key Fob, Garage, Garage Bay, and Panel Glass Break..

jsb5151 commented 2 years ago

@jsb5151 Can you look at the questions I asked?

I'm not sure what you're referring to...?

roopesh commented 2 years ago

  1. Why are you removing the source_key and version_key?

  2. I am still curious why safety would be the catch-all