search

rooseveltframework / semantic-forms

🎯 A pattern library of forms based on semantic HTML enhanced with a modern UX.
Other
8 stars 4 forks source link

input type="image" not fully handled yet #50

Closed kethinov closed 2 months ago

kethinov commented 1 year ago

Needs more CSS love and attention.

ijklmopffs commented 1 year ago

Hey, I'd be willing to work on this

kethinov commented 1 year ago

Sure, go for it! General info on how to hack the code and do a build is at the bottom of the README.

To get started to see the problem, try changing this line to:

<li><input type="image" name="image" value="Button 2"></li>

Then I think you'll see what I mean about it not looking very good yet. There isn't much code in this repo to handle input[type="image"] yet.

More info about input[type="image"] here.

ijklmopffs commented 1 year ago

Alright, will get on it

On Thu, Apr 20, 2023, 2:56 AM Eric Newport @.***> wrote:

Sure, go for it! General info on how to hack the code and do a build is at the bottom of the README https://github.com/kethinov/semanticforms.

To get started to see the problem, try changing this line https://github.com/kethinov/semanticforms/blob/b09603fe4f9201005867ba987fd9ccc8125c5159/semanticForms.html#L126 to:

    • Then I think you'll see what I mean about it not looking very good yet. There isn't much code in this repo to handle input[type="image"] yet.

    More info about input[type="image"] here https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/image.

    — Reply to this email directly, view it on GitHub https://github.com/kethinov/semanticforms/issues/50#issuecomment-1515604165, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXVPPE4YXV3ZCAPMPSX44KTXCCJWPANCNFSM6AAAAAAXAXTUQ4 . You are receiving this because you commented.Message ID: @.***>