roosmaa / ledger-app-nano

Ledger Nano X, Nano S & Blue applications for NANO and derivative coins
Apache License 2.0
35 stars 10 forks source link

use paging instead of autoscroll and confirm with both buttons #5

Open My1 opened 4 years ago

My1 commented 4 years ago

general Ledger UX is now apparently for transaction data to not scroll and change at arbitrary times but rather to offer a paging mechanism where you can jump between parts of adresses and and all the stuff, as well as at the end there are 2 extra pages: one for deny and one for accept, which then is confirmed with pressing both buttons at the same time

roosmaa commented 4 years ago

I guess the Ledger NanoX UX was backported to Ledger Nano apps then? thinking out loud Maybe it would be a simple case of replacing the Ledger Nano UI code with Nanox UI code and it would work.

Right now, however, I don't have the Ledger development environment setup anymore, so I don't know when I'll get around to looking into this feature request. If someone else wants to take up the challenge before I get around to it, I'd be more than happy to review the PR.

My1 commented 4 years ago

I am not sure about the details but currently you generally have it that you split the address into as many parts as needed, and make seperate pages for each which you just scroll through with the left and right buttons, which makes validation and stuff a LOT easier since you dont need to wait for the text being where you need it at the time you need it.

and press both to confirm seems at least for me a lot more affirmative

My1 commented 3 years ago

any news if I may ask?

ilius commented 3 years ago

Personally I like the old UX, because with new UX we have to press the buttons so many times. And I assume buttons would probably be the first thing that breaks on the hardware.

Other coins have fees that also need confirmation. But Nano only has the address. And we generally only need to confirm 2-3 characters from beginning and end of address. Which is totally possible with the old UX.