roost-io / roost-support

Other
0 stars 3 forks source link

not able to exit from rkt cli #4

Open owlmaniac opened 4 years ago

owlmaniac commented 4 years ago

Description: I'm not able to exit from rkt cli with an exit command or the recommended logout command

Steps to reproduce the behavior:

  1. Install Roost on Linux (my pc details are at the end of this thread)
  2. Open roost and wait for rkt to spin up
  3. Open an rkt terminal and try to exit with "exit" or Ctrl+D or "logout" command

Expected behavior: expecting Ctrl+D to close the current rkt terminal

Link to Screenshot: https://photos.google.com/share/AF1QipP4VtvlfYChDRZGOY6itpT1ra9CKy5dn_UC81QJNYdGLfO_GXnM4od886p6Lz7jfg/photo/AF1QipOYp3Ss7w4XnB6D25yIBGwfv91a1hfkTPxyQchd?key=UDJBdjYxX2ZwcFY4MGFjRXdHTzJOLUxqNkFvTUh3

Desktop: Operating System: Pop!_OS 20.10 Kernel: Linux 5.8.0-7625-generic Architecture: x86-64

Additional context Ideally would like to see exit and Ctrl+D working rather than unfamiliar logout for terminal exit

harishagrawal commented 4 years ago

Enable exit Exit

Or use cross mark for window

On Sun, 25 Oct, 2020, 4:42 PM Yeshwanth Reddy, notifications@github.com wrote:

Description: I'm not able to exit from rkt cli with an exit command or the recommended logout command

Steps to reproduce the behavior:

  1. Install Roost on Linux (my pc details are at the end of this thread)
  2. Open roost and wait for rkt to spin up
  3. Open an rkt terminal and try to exit with "exit" or Ctrl+D or "logout" command

Expected behavior: expecting Ctrl+D to close the current rkt terminal

Link to Screenshot:

https://photos.google.com/share/AF1QipP4VtvlfYChDRZGOY6itpT1ra9CKy5dn_UC81QJNYdGLfO_GXnM4od886p6Lz7jfg/photo/AF1QipOYp3Ss7w4XnB6D25yIBGwfv91a1hfkTPxyQchd?key=UDJBdjYxX2ZwcFY4MGFjRXdHTzJOLUxqNkFvTUh3

Desktop: Operating System: Pop!_OS 20.10 Kernel: Linux 5.8.0-7625-generic Architecture: x86-64

Additional context Ideally would like to see exit and Ctrl+D working rather than unfamiliar logout for terminal exit

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/roost-io/roost-support/issues/4, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABG2JJVAFKCCGS56D3GPCYLSMQBYDANCNFSM4S6IG43A .

owlmaniac commented 4 years ago

Enable exit && exit or enable logout && logout works but I'm still reverting back to my original terminal. From my terminal also exit command doesn't close the terminal window. Here is a Screenshot So the only way seems to be to use the cross mark for closing window

owlmaniac commented 4 years ago

Ideally:

  1. It would be good to have exit and logout enabled by default.
    • Because closing an rkt terminal doesn't terminate the rkt engine, so there's no issue even if we close the terminal accidentally. We can just reconnect.
  2. Would love to see Ctrl+D or exit close the terminal window completely(action which now only happens when we click cross(x) mark) and logout would switch back to my original terminal.
    • The above logout point has a concern, reverting to my original terminal wouldn't change the window name which is "rkt-terminal" by default for rkt terminals.
    • So, not just disabling but also removing logout command from rkt-engine is also an option. Since if i want a terminal i can open a terminal directly as roost supports it.
harishagrawal commented 4 years ago

We will look at option of mapping the exit buttons to behave like the cross(x) mark so as to avoid landing on the regular terminal

owlmaniac commented 4 years ago

Great. Thanks.