search

root-11 / tablite

multiprocessing enabled out-of-memory data analysis library for tabular data.
MIT License
37 stars 8 forks source link

Nim text reader #86

Closed realratchet closed 1 year ago

realratchet commented 1 year ago

I'm likely going to merge this on Monday, you can see if you want to add something else.

I will also rebase so that the test pipeline commits don't spam the commit history.

Known issues: I can't get it to work within Windows pipelines so I'll need help from someone with windows to get python working with nim.

I will also add a fallback to use the old python implementation as a fallback if it throws within nim until we're confident with maintaining nim only implementation.

root-11 commented 1 year ago

Great work! I'll help you with windows on Monday. I have most of the day available. I'll try to start early Monday morning so you can get me working on it.

I also don't see it as a show stopper as we can release it to dce as a .dev version

On Sat, 30 Sept 2023, 13:19 Ratchet, @.***> wrote:

I'm likely going to merge this on Monday, you can see if you want to add something else.

I will also rebase so that the test pipeline commits don't spam the commit history.

Known issues: I can't get it to work within Windows pipelines so I'll need help from someone with windows to get python working with nim.

I will also add a fallback to use the old python implementation as a fallback if it throws within nim until we're confident with maintaining nim only implementation.

You can view, comment on, or merge this pull request online at:

https://github.com/root-11/tablite/pull/86 Commit Summary

File Changes

(32 files https://github.com/root-11/tablite/pull/86/files)

Patch Links:

— Reply to this email directly, view it on GitHub https://github.com/root-11/tablite/pull/86, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA64MJTPCEE3W4QZHQAL3ILX5AE5JANCNFSM6AAAAAA5NQR7RU . You are receiving this because you are subscribed to this thread.Message ID: @.***>

codecov-commenter commented 1 year ago

Codecov Report

Merging #86 (f330b96) into master (ad562ff) will decrease coverage by 0.70%. The diff coverage is 74.93%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##           master      #86      +/-   ##
==========================================
- Coverage   83.04%   82.35%   -0.70%     
==========================================
  Files          24       25       +1     
  Lines        3704     3910     +206     
==========================================
+ Hits         3076     3220     +144     
- Misses        628      690      +62
Files Coverage Δ
tablite/__init__.py 100.00% <100.00%> (ø)
tablite/base.py 87.51% <100.00%> (+0.04%) :arrow_up:
tablite/config.py 100.00% <100.00%> (ø)
tablite/core.py 86.58% <ø> (ø)
tablite/version.py 100.00% <100.00%> (ø)
tablite/import_utils.py 82.35% <88.65%> (+5.22%) :arrow_up:
tablite/nimlite.py 10.76% <10.76%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more