root-cause / v-decompiled-scripts

134 stars 49 forks source link

Decompilation of am_contact_requests did not gracefully fail. #15

Open gir489returns opened 1 month ago

gir489returns commented 1 month ago

https://github.com/root-cause/v-decompiled-scripts/blob/master/am_contact_requests.c#L43147-L43226

It seems the decompiler failed or terminated prematurely inside of func_993's scope and did not finish adding the curly braces. I checked the YSC at 0x2E8E6 with IDA, and I did not see anything weird or out of place the decompiler would trip up on here.

gir489returns commented 1 month ago

It seems this was introduced sometime between the 3095 update and the 3179 update.

Affected: https://github.com/root-cause/v-decompiled-scripts/blob/93f5c88f45720e599ea6619bbe347c98a2a9e669/am_contact_requests.c#L42195-L42274

Not affected: https://github.com/root-cause/v-decompiled-scripts/blob/a4554b1f89ba14c06aab0644aec84bd2fa8ed95d/am_contact_requests.c#L41135-L41216