search

root-gg / plik

Plik is a temporary file upload system (Wetransfer like) in Go.
https://plik.root.gg
Other
1.47k stars 168 forks source link

Fix footer position #407

Closed pbe-axelor closed 2 years ago

pbe-axelor commented 2 years ago

There is a horizontal scrollbar displayed for no reason on all pages.

This is due to footer position.

camathieu commented 2 years ago

Hello,

Thanks for the heads up.

I did some testing and it appears to be more complex fix properly. The footer is not really sticky, sometimes it just stays in the middle of the page (when loading a big file list)

pbe-axelor commented 2 years ago

How do you see this ?

I checked with big file list, the footer is always displayed at the end of the page.

camathieu commented 2 years ago

I had to make slightly more adjustements to make it stick in all configurations with position relative but it's indeed way better like this. See https://github.com/root-gg/plik/commit/92c7d2527dae8a701d5c22f988528db6e8c41eb2

Thank you for your contribution.