search

root-gg / plik

Plik is a temporary file upload system (Wetransfer like) in Go.
https://plik.root.gg
Other
1.47k stars 168 forks source link

Add Download domain alias. #439

Closed d-w-x closed 2 years ago

d-w-x commented 2 years ago

We can use it for CDN, internal download etc.

camathieu commented 2 years ago

Looks good to me but could you please add tests to the PR ?

camathieu commented 2 years ago

I reworked your code a bit and added tests as I want to release 1.3.6 today or maybe tomorrow. I created a new PR with your commit and a rework commit on top : https://github.com/root-gg/plik/pull/443 I'm going to close this one. Thank you very much for your contribution <3.

d-w-x commented 2 years ago

Thanks for your change. I was a little busy last few days, and sorry for the late replay. Actually, I'm not familiar with go, my PR is just the minimal changes which I think could work and passed all existed tests. Thanks for the excellent software.