root-gg / plik

Plik is a temporary file upload system (Wetransfer like) in Go.
https://plik.root.gg
Other
1.49k stars 172 forks source link

plikd create user --password broken, password not set when provided #489

Closed aschils closed 1 year ago

aschils commented 1 year ago

Hello,

Just quickly reporting what I think might be an easy to fix bug with the create user feature. When creating a user and when providing explicitly his password, plikd reports that the password is too short (even if the provided password is very long).

I think the issue is simply that the user password is set only when generated automatically. I have attached a screenshot with my git diff. I tried to submit pull request through github website after forking but apparently it didn't go through for some reason.

image

Regards.

camathieu commented 1 year ago

Hi, many thanks for the bug report, we'll fix that for next release that should happen right after we come back from vacation. We'll keep you posted.

On Mon, Jul 31, 2023, 21:21 Arnaud Schils @.***> wrote:

Hello,

Just quickly reporting what I think might be an easy to fix bug with the create user feature. When creating a user and when providing explicitly his password, plikd reports that the password is too short (even if the provided password is very long).

I think the issue is simply that the user password is set only when generated automatically. I have attached a screenshot with my git diff. I tried to submit pull request through github website after forking but apparently it didn't go through for some reason, I'm sorry but I don't really have time to dig into that right now.

[image: image] https://user-images.githubusercontent.com/5392362/257324624-df9dd9bd-e703-4440-8c41-0bca05d423ea.png

Regards.

— Reply to this email directly, view it on GitHub https://github.com/root-gg/plik/issues/489, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABQ5XPVRZ7LXJS2ETEFWS6LXTAAUNANCNFSM6AAAAAA26WNIXI . You are receiving this because you are subscribed to this thread.Message ID: @.***>

paulkitt commented 1 year ago

Heyhey, the latest docker image still facing this problem. Maybe rebuild current master could fix this issue? Thanks

camathieu commented 1 year ago

1.3.8 will be released today.