makedoc log parser rules tuning

[ferdymercury]

@couet I wanted to suggest a small tuning in the jenkins job root-makedoc-master log parser rules that is currently in place (https://lcgapp-services.cern.ch/root-jenkins/view/ROOT/job/root-makedoc-master/configure):

See also https://lcgapp-services.cern.ch/root-jenkins/view/ROOT/job/root-makedoc-master/lastFailedBuild/parsed_console/

Namely:

1) To remove false positives, where "INFO" in capital letters is being parsed in the middle of a word. --> Force it to be at beginning of line, or matching a whole-word

2) To detect false negatives, where "ERROR" is not now being found if in the middle of a line

3) To detect false negatives, where the string sequence ": warning: " could be searched for.

--> Maybe with https://github.com/root-project/rootspi/blob/master/jenkins/logparser-rules/ROOT-incremental-LogParserRules.txt#L25

Examples of the syntax can be found here, too: https://github.com/root-project/rootspi/blob/master/jenkins/logparser-rules/ROOT-incremental-LogParserRules.txt

[couet]

The file used to define the parsing rules is on the jenkins server and it is:

ok /not really/

# match line starting with 'error ', case-insensitive
error /(?i)^error /

error /: error:/
error /:fatal error:/

# list of warnings here...
warning /NOTEBOOK_CONVERSION_WARNING/

# create a quick access link to lines in the report containing 'INFO'
info /INFO/

# each line containing 'BUILD' represents the start of a section for grouping errors and warnings found after the line.
# also creates a quick access link.
start /BUILD/

[couet]

I cannot modify it. Only Axel can.

[ferdymercury]

Thanks. Based on https://regexr.com/, I would suggest these changes:

1) info /INFO/ --> info /\bINFO\b/ 2) add error /\bERROR\b/ 3) add warning /: warning: /

And some useful additions:

• info /: note: /
• warning /Warning in /
• warning /Warning: /
• error /Error: /

[couet]

I would prefer to first make the build green before adding any new rule.

[ferdymercury]

Sounds good. We could also write the new rules in such a way that they raise "warnings" rather than errors, so that the build is still green after adding them. For example:

warning /\bERROR\b/ instead of error /\bERROR\b/

[couet]

Yes it is green again

[ferdymercury]

This would be my proposal then for modification:

ok /not really/

# match line starting with 'error ', case-insensitive
error /(?i)^error /

error /: error:/
error /:fatal error:/
warning /\bERROR\b/
warning /Error: /

# list of warnings here...
warning /NOTEBOOK_CONVERSION_WARNING/
warning /: warning: /
warning /Warning in /
warning /Warning: /

# create a quick access link to lines in the report containing 'INFO'
info /\bINFO\b/
info /: note: /

# each line containing 'BUILD' represents the start of a section for grouping errors and warnings found after the line.
# also creates a quick access link.
start /BUILD/

[couet]

It looks fine for me. I cannot change that file. @Axel-Naumann has the rights to change it.

[ferdymercury]

I've seen that part of the suggested changes have already been included into the log parser, thanks!

I still see some issues:

• INFO is being improperly parsed in the middle of a word rather than at sentence beginning.
• : error: not parsed
• and some more though I did not check too closely.

[ferdymercury]

@jalopezg-git fyi

[ferdymercury]

@dpiparo do you have write access to the jenkins parser rules?