root-project / root-docker

Docker recipes for ROOT
30 stars 33 forks source link

[doc] Update the command to launch the container with graphics on Linux #26

Closed mapellidario closed 3 years ago

mapellidario commented 3 years ago

Since the default image dockerfile uses

CMD ["root", "-b"]

in order to launch the root container with graphics enabled it is necessary not to pass the batch argument to the root executable, which is achieved using the --entrypoint root argument of docker run.

I have tested the command on Linux, but I guess a similar change will be needed for OSX too.

eguiraud commented 3 years ago

Hi @mapellidario , thanks a lot for the PR! As @amadio mentioned, using --entrypoint is overkill, but it's true the doc should be amended with an explicit call to root as the command. Can you update the PR please?

mapellidario commented 3 years ago

Thanks a lot @eguiraud and @amadio for the prompt reply!

I only updated the command for Linux and did not took the liberty of touching the OSX one since I am not used to it and did not want to make any mistake.

By the way, thank you very much for providing such a method for exploiting root's graphical interface! :) This is going to be super-handy for students and newcomers! Thanks again!

eguiraud commented 3 years ago

Thank you!