search

root-project / root-docker

Docker recipes for ROOT
30 stars 33 forks source link

Add Docker image for ArchLinux #3

Closed kgizdov closed 5 years ago

kgizdov commented 5 years ago

Tested and published on Docker Hub at kgizdov:archlinux-root-extra

amadio commented 5 years ago

@kgizdov Hi. The image failed to build for me, at the boost step. Could you please review? Also, could you please name the directory just arch instead of archlinux? We already have ubuntu, centos, and gentoo instead of ubuntulinux, etc.

kgizdov commented 5 years ago

@amadio what is the boost step? Can you send me the error?

Also, Ubuntu, CentOS & Gentoo are ok, but Arch Linux is the actual named trademark that should be used (policy). I can change the folder name, but it will be incorrect according to naming. Also, arch means architecture a lot of the times.

amadio commented 5 years ago 
Step 32/48 : RUN cd /tmp/pythia && makepkg -sri --asdeps --needed --noconfirm
 ---> Running in 0b793ec3eb53
==> Making package: pythia 8.2.35-5 (Wed Sep 26 13:11:58 2018)
==> Checking runtime dependencies...
==> Installing missing dependencies...
resolving dependencies...
looking for conflicting packages...

Packages (1) boost-1.68.0-1

Total Download Size:    12.13 MiB
Total Installed Size:  165.81 MiB

:: Proceed with installation? [Y/n] 
:: Retrieving packages...
downloading boost-1.68.0-1-x86_64.pkg.tar.xz...
checking keyring...
checking package integrity...
loading package files...
checking for file conflicts...
checking available disk space...
:: Processing package changes...
installing boost...
error: could not extract /usr/include/boost/fusion/view/reverse_view.hpp (Can't create '/usr/include/boost/fusion/view/reverse_view.hpp')
error: could not extract /usr/include/boost/geometry.hpp (Can't create '/usr/include/boost/geometry.hpp')
error: could not extract /usr/include/boost/geometry/algorithms/clear.hpp (Can't create '/usr/include/boost/geometry/algorithms/clear.hpp')
...
amadio commented 5 years ago

@amadio what is the boost step? Can you send me the error?

Also, Ubuntu, CentOS & Gentoo are ok, but Arch Linux is the actual named trademark that should be used (policy). I can change the folder name, but it will be incorrect according to naming. Also, arch means architecture a lot of the times.

Well, AUR still stands for Arch User Repository, and the distro is commonly referred to as only Arch. I don't think that it's a problem to name the directory arch in this context. Also see the screenshot below from the main page of the Arch Wiki, where it's clearly referred to as just Arch ("...differences between Arch and other distributions").

screenshot

kgizdov commented 5 years ago

hmm, that is an error with the package manager not being able to install a package, so not a problem with the Dockerfile per say. Are you sure you have enough disk space? (Docker does not report correct free space inside a build). If all previous steps succeeded, there is no reason why this should fail - this step is equivalent. I am planning on reducing the size of docker (steps), but that would have to wait as I'm busy with other things for the rest of the week.

I am only pointing out the way it's meant to be done according to actual title, which is not the same for the OSes you mentioned. archlinux is the correct way it should be, but I don't personally mind, I'll change it. (Wikis can be edited by anyone :wink:)

amadio commented 5 years ago

I'm building the image on a larger machine to check that it's not some system limitation, and so far it's working. I think that it will finish.

As for the name, it's the official wiki calling it Arch, I really don't see a difference with other distros. Everyone knows Arch, so let's just name it that. They call their Docker image base/devel, so it's not like we are doing any worse :wink:

kgizdov commented 5 years ago

try it now and see if it builds better

amadio commented 5 years ago

I tried the old image on a bigger machine and it worked. If you want to keep it as it was, I think it's fine. I like the changes to use less layers, though. If you think it's ok as it is now, I'll merge.

kgizdov commented 5 years ago

I want to have less layers and reduce the size. It's supposed to be an end-user docker image after all. Could you test the new changes and confirm it works? Thanks.

amadio commented 5 years ago

@kgizdov Sure, I'll test again and then merge.

kgizdov commented 5 years ago

@amadio I've pushed a couple of fixes and now it should be reproducible to build it on any system.

amadio commented 5 years ago

Nice, thanks!