root-project / root-docker

Docker recipes for ROOT
30 stars 33 forks source link

Use an entrypoint to properly start the conda based image #43

Closed chrisburr closed 3 years ago

chrisburr commented 3 years ago

Currently the conda based image for 6.24.00 is broken with this message:

$ docker run --rm -it rootproject/root:6.24.00-conda
root.exe: /home/conda/feedstock_root/build_artifacts/root_base_1618934087320/work/root-source/interpreter/cling/lib/Interpreter/CIFactory.cpp:595: {anonymous}::collectModuleMaps(clang::CompilerInstance&, llvm::SmallVectorImpl<std::__cxx11::basic_string<char> >&)::<lambda(llvm::StringRef, const string&, const string&, std::string&, bool, bool)>: Assertion `llvm::sys::fs::exists(SystemDir) && "Must exist!"' failed.

This is because the environment isn't being activated properly so the CONDA_BUILD_SYSROOT environment variable isn't set. Previously the builds were tolerant of this but it seems I've lost a conda-specific patch as part of the LLVM 9 update. I'll fix it in the conda package as well but regardless it's more correct to set up the environment properly.